Skip to content

Dyninst build - Refactor elfutils build folders #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 13, 2025
Merged

Dyninst build - Refactor elfutils build folders #238

merged 6 commits into from
Jun 13, 2025

Conversation

dgaliffiAMD
Copy link
Collaborator

@dgaliffiAMD dgaliffiAMD commented Jun 9, 2025 •
edited
Loading

  • Set elfutils build folder to external/elfutils, to match other external dependencies
  • Update warning message when using the "DYNINST_BUILD_" style options to make it clearer that the new options are still being set.
  • Declare interfaces for the Dyninst build dependencies with the other "External Packages" in Packages.cmake.

@dgaliffiAMD dgaliffiAMD requested review from jrmadsen and a team as code owners June 9, 2025 16:46
@dgaliffiAMD
Format cmake
72974a2
@dgaliffiAMD
Remove reference to unused DYNINST configuration
c63fe87
@dgaliffiAMD
Declare Dyninst interfaces with other external declarations
217c70f
@dgaliffiAMD
Updated cmake warning message
36c4525 
Update the deprecation warning for "DYNINST_BUILD_${dep}" to make it clearer that the option is being translated to the new option, "ROCPROFSYS_BUILD_${dep}"
@dgaliffiAMD
Fixed the elfutils install
75597c6
@dgaliffiAMD dgaliffiAMD requested a review from pranswarup June 10, 2025 23:47
@dgaliffiAMD dgaliffiAMD merged commit eaaec2c into ROCm:amd-staging Jun 13, 2025
41 of 46 checks passed
@dgaliffiAMD dgaliffiAMD deleted the dyninst-cmake branch June 13, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrmadsen jrmadsen Awaiting requested review from jrmadsen jrmadsen is a code owner

@pranswarup pranswarup Awaiting requested review from pranswarup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dgaliffiAMD